Skip to content

Conversation

shwanton
Copy link

@shwanton shwanton commented Jan 21, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Fabric on macOS implementation:
Shim RCTFabricModalHostViewControllerDelegate to work w/ Fabric

closes #1558

Changelog

[macOS][Added] - Shim RCTFabricModalHostViewControllerDelegate for Fabric

Test Plan

[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTFabricModalHostViewControllerDelegate errors
CleanShot 2023-01-20 at 15 41 01

[x] Build RNTester - iOS w/ Fabric
CleanShot 2023-01-20 at 15 06 36

[x] Build RNTester-macOS w/ Paper - should work
CleanShot 2023-01-20 at 16 03 53

[x] Build RNTester - iOS w/ Paper -
CleanShot 2023-01-20 at 16 11 30

@shwanton shwanton marked this pull request as ready for review January 21, 2023 00:23
@shwanton shwanton requested a review from a team as a code owner January 21, 2023 00:23
@Saadnajmi Saadnajmi merged commit 7e7c35d into microsoft:main Jan 24, 2023
@shwanton shwanton deleted the fabric/shim-rctfabricmodalhostviewcontroller branch January 24, 2023 19:27
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
* [Fabric] Shim RCTFabricModalHostViewControllerDelegate

* whitespace

* Fix bad merge

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
* [Fabric] Shim RCTFabricModalHostViewControllerDelegate

* whitespace

* Fix bad merge

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
# Conflicts:
#	React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
* [Fabric] Shim RCTFabricModalHostViewControllerDelegate

* whitespace

* Fix bad merge

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
# Conflicts:
#	React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shim RCTFabricModalHostViewControllerDelegate

2 participants