[Fabric] Fix misc rendering & build issues #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwanton
changed the title
shwanton
changed the title
Saadnajmi
approved these changes
Jan 24, 2023
…componentview # Conflicts: # React/Fabric/Mounting/ComponentViews/InputAccessory/RCTInputAccessoryComponentView.mm # React/Fabric/Mounting/UIView+ComponentViewProtocol.mm
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Fix RCTLegacyViewManagerInteropComponentView * Fix Fabric crash setting frame * Fix crash w/ first responder * Fix RCTFindTextInputWithNativeId Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
* Fix RCTLegacyViewManagerInteropComponentView * Fix Fabric crash setting frame * Fix crash w/ first responder * Fix RCTFindTextInputWithNativeId Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
* Fix RCTLegacyViewManagerInteropComponentView * Fix Fabric crash setting frame * Fix crash w/ first responder * Fix RCTFindTextInputWithNativeId Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Fix misc rendering & build issues
closes #1573
closes #1570
closes #1571
closes #1566
closes #1565
Changelog
[macOS][Added] - Fix misc rendering & build issues
Test Plan
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTLegacyViewManagerInteropComponentView errors
[x] Build RNTester - iOS w/ Fabric
[x] Build RNTester-macOS w/ Paper - should work
[x] Build RNTester - iOS w/ Paper -
