[Fabric] RCTSurfaceTouchHandler for macOS #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 25, 2023 16:48
Saadnajmi
reviewed
Jan 25, 2023
Saadnajmi
reviewed
Jan 25, 2023
Saadnajmi
reviewed
Jan 25, 2023
React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
reviewed
Jan 25, 2023
Saadnajmi
reviewed
Jan 25, 2023
Saadnajmi
reviewed
Jan 25, 2023
Saadnajmi
reviewed
Jan 25, 2023
ReactCommon/react/renderer/components/view/TouchEventEmitter.cpp
Outdated
Show resolved
Hide resolved
Closed
Saadnajmi
reviewed
Jan 25, 2023
|
@microsoft-github-policy-service agree [company="Facebook"] |
|
@microsoft-github-policy-service agree company="Facebook" |
Saadnajmi
reviewed
Jan 25, 2023
Saadnajmi
approved these changes
Jan 25, 2023
|
Could you take a look why the CI is falling @lenaic ? |
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Add support for z-index to RCTUIView * Add z-index based hitTest implementation for macOS * Add reactTag property to RCTComponentViewProtocol and RCTUIView for macOS * Add macOS specific fields to Touch event * Enable mouse event handling in RCTSurfaceTouchHandler * [Fabric] Fix macOS tags * Remove component view descriptor tag property Co-authored-by: Nick <lefever@meta.com> Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
* Add support for z-index to RCTUIView * Add z-index based hitTest implementation for macOS * Add reactTag property to RCTComponentViewProtocol and RCTUIView for macOS * Add macOS specific fields to Touch event * Enable mouse event handling in RCTSurfaceTouchHandler * [Fabric] Fix macOS tags * Remove component view descriptor tag property Co-authored-by: Nick <lefever@meta.com> Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm # React/Fabric/RCTSurfaceTouchHandler.mm
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
* Add support for z-index to RCTUIView * Add z-index based hitTest implementation for macOS * Add reactTag property to RCTComponentViewProtocol and RCTUIView for macOS * Add macOS specific fields to Touch event * Enable mouse event handling in RCTSurfaceTouchHandler * [Fabric] Fix macOS tags * Remove component view descriptor tag property Co-authored-by: Nick <lefever@meta.com> Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm # React/Fabric/RCTSurfaceTouchHandler.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Update the RCTSurfaceTouchHandler to support mouse events on macOS Fabric and convert them to touch events.
Changelog
[macOS] [Added] - Touch events for Fabric
Test Plan
[x] Build RNTester-macOS w/ Fabric
[x] Click around RNTester-macOS w/ Fabric
https://user-images.githubusercontent.com/151054/214643298-c550a516-2710-40a1-8025-d4f5f9431bdb.mov
[x] Build RNTester - iOS w/ Fabric
[x] Build RNTester-macOS w/ Paper
[x] Build RNTester - iOS w/ Paper
