Respect system proxy settings for WebSocket, take 2 #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 9, 2023 13:05
Saadnajmi
approved these changes
Feb 9, 2023
Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Respect system proxy settings for WebSocket * Update yarn.lock * Update Podfile.lock * Add macOS tags * Revert "Update yarn.lock" This reverts commit 91c448e. * Revert "Update Podfile.lock" This reverts commit f65b797. * nit: fix ending macOS tag Co-authored-by: Saad Najmi <sanajmi@microsoft.com> --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason #1725 didn't merge in the commits I made after feedback. This adds macOS tags and undoes the lock file changes.