Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

The NPM package request is deprecated, and shows up in our component governance alerts. Let's remove references to it.
It is a transitive dependency of two packages:

  • coveralls used by a CircleCI test for code coverage
    • I'll just remove the dependency, and comment out the test. I'll also look into an upstream fix to React Native Core.
  • npm-registry used by react-native-macos-init

Changelog

[Security] [Fixed] - Remove dependency on NPM package request

@Saadnajmi Saadnajmi requested a review from a team as a code owner March 17, 2023 21:42
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 17, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants