Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Aug 16, 2023

TL;DR

I made an error, and now the 0.71-stable NPM package & Github branch are out of sync in package versions. This PR rectifies that.

Longer Explanation

As it turns out, with my admin privileges, I can push directly to the repos' 0.71-stable branch. This led to this unfortunate set of events:

  1. I accidentally committed directly to 0.71-stable with 3770a1a, which caused the publish pipeline to run.
  2. I tried to fix this issue by changing settings so that nobody could push a commit to a *-stable branch.
  3. Unfortunately, that meant that even rnbot (the bot that publishes to NPM for us and pushes the version update back to Github) couldn't push to the branch, and the publish pipeline job succeeded in publishing to NPM, but not back to Github

Result: NPM has 0.71.33, while our repo only has 0.71.32. We can fix this by just manually bumping the version in Github ourselves, and adding ***NO_CI*** to the merged commit so that the publish pipeline doesn't run again.

@Saadnajmi Saadnajmi requested a review from a team as a code owner August 16, 2023 09:43
@Saadnajmi Saadnajmi enabled auto-merge (squash) August 16, 2023 09:43
@Saadnajmi Saadnajmi merged commit 57b878f into microsoft:0.71-stable Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants