Skip to content

Conversation

amgleitman
Copy link
Member

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This is an alternative to #1910 where we cherry-pick a commit from upstream that fixes the problem in a slightly different way.

This ensures that PROJECT_ROOT has the correct value so the JS bundler knows how to resolve things properly.

Changelog

[INTERNAL] [FIXED] - Specify PROJECT_ROOT in rn-tester yarn start script

Test Plan

Launched RNTester using the bundler from yarn start, and it works.

@amgleitman amgleitman merged commit 289e5c6 into microsoft:main Aug 23, 2023
@amgleitman amgleitman deleted the rn-tester-cherry-pick-40f816d branch August 23, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants