Skip to content

Conversation

acoates-ms
Copy link
Collaborator

@acoates-ms acoates-ms commented Nov 19, 2019

RCTWebView was removed from react-native in 0.60. Removing the reference to it in the cmake file.

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Nov 19, 2019

Hello @acoates-ms!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@pull-bot
Copy link

pull-bot commented Nov 19, 2019

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 736a6c6

@acoates-ms acoates-ms merged commit 6190bbc into microsoft:master Nov 19, 2019
@acoates-ms acoates-ms deleted the fixcmake branch November 19, 2019 21:09
lenaic pushed a commit to lenaic/react-native-macos that referenced this pull request Jul 15, 2025
Summary:
Pull Request resolved: facebook#52585

Changelog: [Internal] - Update `react-native/debugger-frontend` from 844f225...8dc0d5b

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@844f225...8dc0d5b).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [8dc0d5b36](facebook/react-native-devtools-frontend@8dc0d5b36) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-14T18:03:52+01:00 | [improve current session id message selectivity (microsoft#192)](facebook/react-native-devtools-frontend@8dc0d5b36) |
| [0a50c353c](facebook/react-native-devtools-frontend@0a50c353c) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-14T16:33:55+01:00 | [Track Stack Trace Frames Succeed / Fail to Resolve URL (microsoft#191)](facebook/react-native-devtools-frontend@0a50c353c) |
| [fc0a2e77e](facebook/react-native-devtools-frontend@fc0a2e77e) | Alex Hunt (hello@alexhunt.dev) | 2025-07-14T12:41:58+01:00 | [Tweak wording for Network dogfooding banner (microsoft#193)](facebook/react-native-devtools-frontend@fc0a2e77e) |
| [efa49bd7a](facebook/react-native-devtools-frontend@efa49bd7a) | sbuggay (sbuggay@gmail.com) | 2025-07-11T06:17:05-07:00 | [Update README.md (microsoft#190)](facebook/react-native-devtools-frontend@efa49bd7a) |

Reviewed By: huntie

Differential Revision: D78281338

fbshipit-source-id: 2cbc15e0e53919f7164fca009c0dcad93d333c72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants