Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

This PR fixes two followup issues uncovered on our publish pipeline:

  1. @react-native-mac/virtualized-lists v0.73.3 got published to NPM, but the followup git commit to delete the change file and bump versions never happened. Let's manually sync by doing both.

  2. In 0.73-stable, some of the upstream NPM publish scripts got refactored that removed some of our diffs to not use the process.env.CIRCLE_TAG variable. Let's just bring back our diff to use the package.json version instead of relying on a CircleCI environment variable.

Changelog:

[INTERNAL] [FIXED] - Fix more CI issues

Test Plan:

CI should pass.

@Saadnajmi Saadnajmi requested a review from a team as a code owner December 27, 2023 22:55
@Saadnajmi Saadnajmi merged commit 50bec0c into microsoft:main Dec 27, 2023
@Saadnajmi Saadnajmi deleted the fix-ci-2 branch December 27, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants