Skip to content

Conversation

HeyImChris
Copy link

@HeyImChris HeyImChris commented Dec 10, 2019

…eds to succeed

  • [ X] I am making a fix / change for the macOS implementation of react-native
  • [ X] I am making a change required for Microsoft usage of react-native

In SDX-Platform, the publish step is failing to create the nuget because that relies on three targets only used in the publish step. This PR fixes those three targets so they build by updating their dependencies.

Tom is making another fix to our pipeline so that changes can't get checked in unless these 3 targets also pass because right now a change went in overwriting the dependencies of these targets, succeeded, was checked in, but now no build can publish because these are broken.

Focus areas to test

All it has to do is build, which they all do now. Once it's in github we can migrate it to sdx-platform and make sure publishes succeed again.

Microsoft Reviewers: Open in CodeFlow

@HeyImChris HeyImChris merged commit 9bd79f3 into master Dec 10, 2019
@acoates-ms acoates-ms deleted the chrishog/fixPublishBuilds branch December 10, 2019 18:14
rozele pushed a commit to rozele/react-native-macos that referenced this pull request Sep 16, 2025
Summary:
Pull Request resolved: facebook#53789

Changelog: [Internal] - Update `react-native/debugger-frontend` from 5a792db...8b84a77

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@5a792db...8b84a77).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [8b84a77b2](facebook/react-native-devtools-frontend@8b84a77b2) | Ruslan Lesiutin (28902667+hoxyq@users.noreply.github.com) | 2025-09-15T17:28:39+01:00 | [fix: avoid race conditions when fetching background trace (microsoft#206)](facebook/react-native-devtools-frontend@8b84a77b2) |
| [95bd36ce9](facebook/react-native-devtools-frontend@95bd36ce9) | Ruslan Lesiutin (28902667+hoxyq@users.noreply.github.com) | 2025-09-15T14:45:07+01:00 | [feat: use application display name for trace title (microsoft#207)](facebook/react-native-devtools-frontend@95bd36ce9) |

Reviewed By: huntie

Differential Revision: D82464061

fbshipit-source-id: c33db7a535a148f8316730009580aef00afe04f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants