Skip to content

Conversation

tom-un
Copy link
Collaborator

@tom-un tom-un commented Jan 24, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

In previous commits changes were made to add arm64e as an arch for all iOS react libs. In recent merges from facebook to the microsoft fork two new targets were added: jsi and jsiExecutor. These two newer targets also need arm64e.

Test apps, like RNTester, also need the arm64e architecture when deploying to devices with A12 processors like the iPhone XS/XR and higher.

Microsoft Reviewers: Open in CodeFlow

@tom-un tom-un requested a review from acoates-ms as a code owner January 24, 2020 00:25
@tom-un tom-un requested a review from HeyImChris January 24, 2020 00:26
@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 5552c36

13B07F941A680F5B00A75B9A /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ARCHS = (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make sure this works with Cocoapods enabled?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I suspect its going to be a change to the new Cocoapod changes for macOS for both the React libs and for RNTester.

@tom-un tom-un merged commit b1a11c6 into microsoft:master Jan 24, 2020
@tom-un tom-un deleted the tomun/arm64 branch May 8, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants