Skip to content

Remove react-native commands from cli when installed as 'react-native-macos' #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Remove react-native commands from cli when installed as 'react-native-macos' #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea158ef
Add logic to remove ios and android commands from react-native cli wh…
tom-un Jan 24, 2020
6124a50
Linted the js
tom-un Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,14 @@
const ios = require('@react-native-community/cli-platform-ios');
const android = require('@react-native-community/cli-platform-android');

// Remove commands so that react-native-macos can coexist with react-native in repos that depend on both.
const path = require('path');
const isReactNativeMacOS = path.basename(__dirname) === 'react-native-macos';
const iosCommands = isReactNativeMacOS ? [] : ios.commands;
const androidCommands = isReactNativeMacOS ? [] : android.commands;

module.exports = {
commands: [...ios.commands, ...android.commands],
commands: [...iosCommands, ...androidCommands],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need a ...macCommands here too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will, but mac commands don't exist yet. We have to create a @react-native-community/cli-platform-macos package first.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the commands can be in this repo. No need to make that a separate repo. Windows implements its commands within react-native-windows.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason the android and ios ones are separate is so that the community can handle the PRs etc without waiting on facebook, since facebook doesn't use the cli.

platforms: {
ios: {
linkConfig: ios.linkConfig,
Expand Down