Skip to content

Conversation

tom-un
Copy link
Collaborator

@tom-un tom-un commented Jan 27, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

This change begins publishing a react-native-macos package to npmjs.org.

At this time we can't just rename the package from react-native to react-native-macos in the package.json because we still publish a react-native package to an internal npm feed used widely within Microsoft. In the meantime a simple node script step renames the name in package.json just prior to performing npm publish to npmjs. After we migrate all internal consumers to use the public npm package, this script step can go away and the package.json name can be changed to react-native-macos.

Microsoft Reviewers: Open in CodeFlow

@tom-un tom-un requested a review from acoates-ms as a code owner January 27, 2020 23:20
@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against c8162b7

@tom-un tom-un merged commit 0569058 into microsoft:master Jan 27, 2020
@tom-un tom-un deleted the tomun/npm branch May 8, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants