Restore macOS <Image> and ActionSheetIOS. Cherry pick multi windows UIScene support from upstream. #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Since the last merge from upstream to the fork two manual merge errors impacted macOS:
RCTImageView.m
the macOS version of the_imageView
ivar was not being initialized breaking<Image>
components.react-native-implementation.macos.js
theActionSheetIOS
component was not being exposed. Although namedActionSheetIOS
in the fork it createsNSMenu
popups for macOS andUIAlertControllers
for iOS.Since iOS 13 the
RCTKeyWindow()
function is broken in apps that useUIScene
's for multi window support. It also breaksRCTRedBox
. If an app that usesUIScene
's (like Office apps) show anRCTRedBox
error message, the red box window is invisible. Then if aActionSheetIOS
presents aUIAlertController
it is presented on the invisible Red Box windows making the action sheet or alert invisible. Cherry pick the upstream fix facebook#28147. Future merges into this fork from upstream will get the more comprehensiveUIScene
support that started with facebook#28058.Focus areas to test
The Image test in RNTester was used to verify that
components is restored. UIScene support was tested by manually integrating this branch into Office.
Microsoft Reviewers: Open in CodeFlow