Send mouse up notifications for all enabled NSControls #263
Conversation
…ry other click from registering
| NSView *targetView = [self.view hitTest:touchLocation]; | ||
| if ([targetView isKindOfClass:NSText.class]) { | ||
| if ([targetView isKindOfClass:[NSControl class]]) { | ||
| _shouldSendMouseUpOnSystemBehalf = [(NSControl*)targetView isEnabled]; |
There was a problem hiding this comment.
I suspect we will continuously be adding new cases and exceptions here, though this seems reasonable as a temporary unblock. How far down the path of removing _shouldSendMouseUpOnSystemBehalf and the spoof event it creates did you go and do we have a sense of what complexity makes it currently difficult to get rid of that? Would be great to add in comments so next person looking at the code can benefit from your investigation.
There was a problem hiding this comment.
I haven't tried removing it entirely, but I also don't think there are too many other cases in the future we'd hit. Almost every control we need to send mouse events for is an NSControl or NSText object.
There was a problem hiding this comment.
For now probably, but you could easily imagine different types of NSViews in the future needing this. And just isEnabled/isSelected is super unlikely to cover all scenarios
There was a problem hiding this comment.
For the comment, I more meant commenting on what blocks us from removing this hack altogether
There was a problem hiding this comment.
Agreed that it's possible that different controls in the future require more edits here. If touch handler bugs end up taking a lot of time then I think it's worth investigating rewriting this, but that's not the case now and I'm not convinced it will be any time soon.
3 participants
Please select one of the following
When controls such as NSButton don't send the mouse up signal after a mouse down click, the mouse event gets stored in our cache and becomes stale. On the next click, we fail an assert that there are no stale events in our cache and no action is executed.
What we need to do is send the mouse up signal for all controls that can receive one so we clear out our cache properly. We need to pair the mouse down events 1:1 with the mouse up events we send.
Focus areas to test
Tested in a downstream app (Polyester). Clicking every time registers and sends the correct event (dropping a menu in this case). Tested with both soft trackpad and hard trackpad clicks.
Microsoft Reviewers: Open in CodeFlow