feat(fabric): Add macOS host platform to ReactCommon #2690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Sep 16, 2025
...nderer/components/view/platform/macos/react/renderer/components/view/HostPlatformViewProps.h
Show resolved
Hide resolved
Saadnajmi
commented
Sep 16, 2025
...nents/view/platform/macos/react/renderer/components/view/HostPlatformViewTraitsInitializer.h
Outdated
Show resolved
Hide resolved
Saadnajmi
changed the title
Saadnajmi
commented
Sep 16, 2025
...act/renderer/components/view/platform/macos/react/renderer/components/view/MacOSViewEvents.h
Outdated
Show resolved
Hide resolved
Saadnajmi
commented
Sep 16, 2025
...act/renderer/components/view/platform/macos/react/renderer/components/view/MacOSViewEvents.h
Show resolved
Hide resolved
Saadnajmi
force-pushed
the
host-platform
branch
from
43c25ad to
45957ea
Compare
|
Another Q: Should we exclude the They're all files that most just namespace the base class, so they're safe to compile. namespace facebook::react {
using HostPlatformFoo= BaseFoo;
} // namespace facebook::reactThe annoying part is they both show up in Xcode and it's hard to tell which one you want to edit. The counterargument would be that we would have different files included in our build for iOS vs macOS which might make building more annoying |
Saadnajmi
force-pushed
the
host-platform
branch
from
45957ea to
1a0b81a
Compare
acoates-ms
approved these changes
Sep 17, 2025
Saadnajmi
added a commit
that referenced
this pull request
Sep 19, 2025
Needs #2690 to land first. ## Summary: Implement focus on RCTViewComponentView. Much of the implementation is taken from #1437, #2117 and comparing against `RCTView`. The border path used for `drawFocusRingMask` is the same as what is used for box shadows and cursors. ## Test Plan: The focus loop seems nonexistent on both paper and Fabric in RNTester... but I can verify that calling `ref.current?/.focus()` on a Pressable displays the focus ring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new macOS host platform folder, with overrides for some of the HostPlatform* files to implement some macOS only props. This follows the pattern in React Native Core that Android uses, and what React Native Windows does.
Some notes:
RCTPullToRefreshViewComponentView.mm. This is later fixed upstream so we can remove the diff then.RCTViewComponentViewyet, that will be in a future PR)Test Plan:
CI should pass.