Fix issue #2706: Add proper constraints for macOS dev loading view #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g view - Add contentView initialization and container constraints for macOS - Fix layout issues with the dev loading view on macOS platform - Ensure proper positioning and sizing of the loading message window Fixes microsoft#2706
|
@microsoft-github-policy-service agree [company="{didi}"] |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree |
|
This is the effect after the repair. |
|
Saadnajmi
reviewed
Sep 30, 2025
Comment on lines
178
to
179
| self->_window.contentView = [[NSView alloc] init]; | ||
| [self->_window.contentView addSubview:self->_container]; |
There was a problem hiding this comment.
Doesn't this invalidate line 152? Should we doing it there instead?
There was a problem hiding this comment.
I have completed the modifications according to your suggestions.
Comment on lines
181
to
192
| [NSLayoutConstraint activateConstraints:@[ | ||
| [self->_container.topAnchor constraintEqualToAnchor:self->_window.contentView.topAnchor], | ||
| [self->_container.leadingAnchor constraintEqualToAnchor:self->_window.contentView.leadingAnchor], | ||
| [self->_container.trailingAnchor constraintEqualToAnchor:self->_window.contentView.trailingAnchor], | ||
| [self->_container.bottomAnchor constraintEqualToAnchor:self->_window.contentView.bottomAnchor], | ||
|
|
||
| // Label constraints | ||
| [self->_label.centerXAnchor constraintEqualToAnchor:self->_container.centerXAnchor], | ||
| [self->_label.centerYAnchor constraintEqualToAnchor:self->_container.centerYAnchor], | ||
| [self->_label.leadingAnchor constraintGreaterThanOrEqualToAnchor:self->_container.leadingAnchor constant:10], | ||
| [self->_label.trailingAnchor constraintLessThanOrEqualToAnchor:self->_container.trailingAnchor constant:-10], | ||
| ]]; |
There was a problem hiding this comment.
Any chance we can share a bunch of these constraints with the iOS block?
There was a problem hiding this comment.
I have completed the modifications according to your suggestions.
- Replace contentViewController.view with contentView for proper view hierarchy - Unify constraint logic across iOS and macOS platforms - Use shared constraint array for better code organization - Fix container constraints to properly fill parent view on macOS - Maintain platform-specific label positioning (bottom on iOS, center on macOS) Fixes issue microsoft#2706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2706
Summary:
Test Plan: