forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 149
feat(fabric): Implement mouse events #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
06f4930
[fabric] Add mouse event props to View
d655dd4
[fabric] Add mouse enter/leave tracking to the View component
2814ae2
[fabric] Disable view flattening for views using mouse events
0327eed
[fabric] Check for assigned event emitter before sending key/mouse ev…
dff7ce8
[fabric] Add mouse enter/leave tracking on scroll
5f334af
Followup changes
Saadnajmi 9b2d400
Apply change from #1971 to Fabric
Saadnajmi 9d2ec8f
sendMouseEvent --> emitMouseEvent
Saadnajmi 6573a89
Update HostPlatformViewEvents.h
Saadnajmi 9af4715
move if check
Saadnajmi bcfa35e
left align ampersands
Saadnajmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...react/renderer/components/view/platform/macos/react/renderer/components/view/MouseEvent.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include <react/renderer/graphics/Geometry.h> | ||
|
||
namespace facebook::react { | ||
|
||
/* | ||
* Describes a mouse enter/leave event. | ||
*/ | ||
struct MouseEvent { | ||
/** | ||
* Pointer horizontal location in target view. | ||
*/ | ||
Float clientX{0}; | ||
|
||
/** | ||
* Pointer vertical location in target view. | ||
*/ | ||
Float clientY{0}; | ||
Saadnajmi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/** | ||
* Pointer horizontal location in window. | ||
*/ | ||
Float screenX{0}; | ||
|
||
/** | ||
* Pointer vertical location in window. | ||
*/ | ||
Float screenY{0}; | ||
|
||
/* | ||
* A flag indicating if the alt key is pressed. | ||
*/ | ||
bool altKey{false}; | ||
|
||
/* | ||
* A flag indicating if the control key is pressed. | ||
*/ | ||
bool ctrlKey{false}; | ||
|
||
/* | ||
* A flag indicating if the shift key is pressed. | ||
*/ | ||
bool shiftKey{false}; | ||
|
||
/* | ||
* A flag indicating if the meta key is pressed. | ||
*/ | ||
bool metaKey{false}; | ||
}; | ||
|
||
} // namespace facebook::react |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.