forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 149
Deduplicate several JavaScript files #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew." This reverts commit 5a67ae0.
|
markavitale
approved these changes
Apr 29, 2020
anandrajeswaran
approved these changes
Apr 29, 2020
HeyImChris
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
There were several JavaScript files in the fork that were direct copies of files upstream: where upstream there was a
Foo.ios.js
, in this fork we copied it toFoo.macos.js
. When merging changes from upstream it is an error prone process to keep these copied files in sync. This change removes the contents of most of theseFoo.macos.js
files and changes them to simplyrequire('./Foo.ios.js')
. There were a couple files that upstream had aBar.ios.js
andBar.android.js
and in the fork we renamedBar.ios.js
toBar.js
to share with mac. These files have been restored toBar.ios.js
andBar.macos.js
has been created that simply does arequire('./Bar.ios.js')
. A few other.macos.js
files had inconsistent comment headers with their other platform counterparts. Finally, there were a few ejected components that still had old.macos.js
files hanging around -- they have been deleted.Focus areas to test
Full automated test suite pass, manual testing of RNTester.
Microsoft Reviewers: Open in CodeFlow