Skip to content

fix: configure throws when package.json is missing #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: configure throws when package.json is missing #2063

merged 1 commit into from
Jun 7, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 5, 2024

Description

configure throws when package.json is missing

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

git clone https://github.com/react-native-async-storage/async-storage.git
cd async-storage
yarn
cd packages/default-storage/example
yarn configure-test-app -p android -p ios -f

@tido64 tido64 requested a review from acoates-ms June 5, 2024 07:04
@tido64 tido64 requested a review from kelset as a code owner June 5, 2024 07:04
@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Jun 5, 2024
@tido64 tido64 merged commit 6ee6a75 into trunk Jun 7, 2024
@tido64 tido64 deleted the tido/fix-configure branch June 7, 2024 06:08
@vonovak vonovak mentioned this pull request Jun 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@kelset kelset Awaiting requested review from kelset

Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @acoates-ms