Skip to content

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 20, 2024

Description

Nightlies are failing because of ReactNativeDir being set. I'm not entirely sure why, but unsetting it makes the errors go away:

- Build failed with message D:\a\react-native-test-app\react-native-test-app\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\TurboModule.cpp(9,10): error C1083: Cannot open include file: 'react/debug/react_native_assert.h': No such file or directory [D:\a\react-native-test-app\react-native-test-app\example\node_modules\.generated\windows\UWP\ReactTestApp.vcxproj]. Check your build configuration.

-- https://github.com/microsoft/react-native-test-app/actions/runs/9591391859/job/26448224357

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version canary-windows
yarn clean
yarn
cd example
yarn install-windows-test-app --use-nuget
yarn windows

@github-actions github-actions bot added the platform: Windows This affects Windows label Jun 20, 2024
@tido64
Copy link
Member Author

tido64 commented Jun 20, 2024

FYI @Yajur-Grover

@tido64 tido64 merged commit 56b7293 into trunk Jun 21, 2024
@tido64 tido64 deleted the tido/windows/fix-canary-builds branch June 21, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Windows This affects Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants