Skip to content

fix(windows): update template to set paths dynamically #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(windows): update template to set paths dynamically #2249

merged 1 commit into from
Sep 18, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 18, 2024 •
edited
Loading

Description

A new rnwPathFromProjectRoot parameter was recently introduced to calculate the path correctly from the project's root directory.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version canary-windows
yarn
cd example
yarn install-windows-test-app --use-fabric
yarn windows

# In a separate terminal
yarn start

@github-actions github-actions bot added the platform: Windows This affects Windows label Sep 18, 2024
@tido64 tido64 mentioned this pull request Sep 18, 2024
Closed
5 tasks
@tido64 tido64 merged commit afe68dc into trunk Sep 18, 2024
27 checks passed
@tido64 tido64 deleted the tido/windows/update-template branch September 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonVMo JasonVMo JasonVMo approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

Assignees
No one assigned
Labels
platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @JasonVMo