Skip to content

Conversation

kraenhansen
Copy link
Contributor

Description

Resolves #2283 by adding single quotes around the path being written to the .env file.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

I reproduced this locally, applied the patch and verified the fix.

@tido64
Copy link
Member

tido64 commented Oct 18, 2024

Thanks 😊

@tido64 tido64 merged commit e6952ef into microsoft:trunk Oct 18, 2024
26 of 27 checks passed
@kraenhansen kraenhansen deleted the kh/node-bin-escaped branch October 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Embed Manifest" script phase fails if node's path contains a space
2 participants