fix(apple): always enable Hermes from 0.80+ #2444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonVMo
approved these changes
Apr 9, 2025
| return "from-source"; | ||
| // Hermes prebuilds for visionOS was introduced in 0.76 | ||
| if ( | ||
| enabled && |
There was a problem hiding this comment.
It might be better to centralize these types of settings into capabilities. Maybe a function that returns an object with various capabilities given a RN version and process.env settings. It ends up being easier to manage. Doesn't need to be done now but something for you to consider.
There was a problem hiding this comment.
That's what this function is used for. See https://github.com/microsoft/react-native-test-app/blob/trunk/ios/app.mjs#L236-L255 and the tests in https://github.com/microsoft/react-native-test-app/blob/trunk/test/ios/app.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With JSC no longer being a part of core from 0.80, we will also drop support for it.
Resolves #2436.
Platforms affected
Test plan
n/a