[0.74] Backport various fabric fixes #13960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce ReactNativeAppBuilder.idl * yarn format fix * Change files * Address feedback * Add a fabric check for ReactNativeAppBuilder * yarn format
* Update SampleAppFabric to use ReactNativeAppBuilder * Yarn format fix * Address feedback to keep BUNDLE and DEBUG * Yarn format * Change files * Setup the DebugBundlePath when loading from metro
* Build reactnativeappbuilder * Setup reactnativewin32 app * Fix dispatcherqueue issue * Change files * Cleanup * Address feedback * Address feedback2 * Fix pipeline error * Fix pipeline errors * Address feedback
This PR provides a proper implementation of the `SampleTurboModule` module and removes the proxy code in `TurboModuleManager` which instead substituted the old `SampleTurboCxxModule` module. - New feature (non-breaking change which adds functionality) The APIs of `SampleTurboModule` are starting to deviate from the older `SampleTurboCxxModule`, specifically the addition of new `EventEmitter` members. So it's time we had a "real" implementation of `SampleTurboModule`. Closes microsoft#13531 See above. N/A Verified tests still pass and the new module is being called. Should this change be included in the release notes: _yes_ Implement the SampleTurboModule module
* [Fabric] Fix crash when running inspect * Change files * fix
* [Fabric] Enable ScrolView touch scrolling * Change files * format * typo
…on (microsoft#13674) * Add Implementation for accessibilityActions * Add activate action * Format * Change files
…soft#13675) * [Fabric] LogBox should destroy its window on instance shutdown * Change files * format
… command handling (microsoft#13857) * [Fabric] Add FocusNavigationDirection and allow overriding of default command handling * Change files * revert packages.lock
…less mode (microsoft#13905) * Use a legacy native module binding that always returns null in bridgeless mode * Change files * format
…hen using web debugger (microsoft#13911) * SampleTurboModule only works as a turbomodule, so do not install it when using web debugger * Change files * fix
TatianaKapos
approved these changes
Oct 11, 2024
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Yajur-Grover
approved these changes
Oct 11, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the following changes into 0.74:
#13368
#13382
#13467
#13541
#13592
#13664
#13674
#13675
#13857
#13866
#13905
#13911
Microsoft Reviewers: Open in CodeFlow