test(jsnum): add binary/oct/hex BigInt cases including underscores and uppercase prefixes #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harsh1925
force-pushed
the
test/jsnum-more-bases-clean
branch
from
e61e1e2 to
81a982e
Compare
|
I’ve rebased, formatted with dprint, and CI is now green. Could you take another look when you have a moment? |
jakebailey
reviewed
Sep 9, 2025
|
Removed the resolved TODO and ran dprint fmt on the test file. Thanks! |
jakebailey
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for ParsePseudoBigInt across non-decimal bases, responding to the
inline TODO ("tests for other bases") in internal/jsnum/pseudobigint_test.go.
No behavior changes; tests pass with the current implementation.