Skip to content

test(jsnum): add binary/oct/hex BigInt cases including underscores and uppercase prefixes #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

test(jsnum): add binary/oct/hex BigInt cases including underscores and uppercase prefixes #1678

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9186fe0
test(jsnum): add binary/oct/hex BigInt cases incl. underscores and up…
Harsh1925 Sep 2, 2025
81a982e
format(jsnum): apply dprint to pseudobigint_test.go
Harsh1925 Sep 9, 2025
9c4a87b
test(jsnum): remove resolved TODO
Harsh1925 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion internal/jsnum/pseudobigint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,41 @@ func TestParsePseudoBigInt(t *testing.T) {
}
})

// TODO(jakebailey): tests for other bases
t.Run("parse non-decimal bases (small numbers)", func(t *testing.T) {
t.Parallel()

type tc struct {
lit string
out string
}
cases := []tc{
// binary
{lit: "0b0n", out: "0"},
{lit: "0b1n", out: "1"},
{lit: "0b1010n", out: "10"},
{lit: "0b1010_0101n", out: "165"},
{lit: "0B1101n", out: "13"}, // uppercase prefix

// octal
{lit: "0o0n", out: "0"},
{lit: "0o7n", out: "7"},
{lit: "0o755n", out: "493"},
{lit: "0o7_5_5n", out: "493"},
{lit: "0O12n", out: "10"}, // uppercase prefix

// hex
{lit: "0x0n", out: "0"},
{lit: "0xFn", out: "15"},
{lit: "0xFFn", out: "255"},
{lit: "0xF_Fn", out: "255"},
{lit: "0X1Fn", out: "31"}, // uppercase prefix
}

for _, c := range cases {
got := ParsePseudoBigInt(c.lit)
assert.Equal(t, got, c.out, "literal: %q", c.lit)
}
})

t.Run("can parse large literals", func(t *testing.T) {
t.Parallel()
Expand Down
Loading