[shaderwriter] Add new port. #14088
Merged
[shaderwriter] Add new port. #14088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangL
added
the
category:new-port
LilyWangL
suggested changes
Oct 19, 2020
Merged
LilyWangL
suggested changes
Oct 20, 2020
LilyWangL
approved these changes
Oct 21, 2020
LilyWangL
added
info:reviewed
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [New Port Request] ShaderWriter #13894 .
Which triplets are supported/not supported? Have you updated the CI baseline?
I have tested
x64-windows,x64-windows-static,x86-windows,x64-linuxandx64-osx, and I expect the other ones to build as well.The CI baseline has not been updated.
Does your PR follow the maintainer guide?
Yes.