Notebooks do not work with typical two-panel git diff view

[wamartin-aml]

Bug: Notebook Editor, Interactive Window, Python Editor cells

Steps to cause the bug to occur

1. Open .ipynb file with this extension enabled.
2. Make changes to document.
3. Save changes to document.
4. Wait for changes to show up under "CHANGES" in the source control window
5. Click on the file name in the source control window

Actual & Expected behavior

Expected: A two-panel git diff shows up showing unstaged changes
Actual: A new window appears and then closes. A notification pops up with

Failed to show text document git:/mnt/c/Users/wamartin/home/[my notebook path]?%7B%22path%22%3A%22%2Fmnt%2Fc%2FUsers%2Fwamartin%2Fhome%2F[my notebook path]%22%2C%22ref%22%3A%22~%22%7D, should show in editor #undefined

Your Jupyter and/or Python environment

Please provide as much info as you readily know

• Jupyter server running: Local (I think? I didn't start anything, but there is a kernel running)
• Extension version: 2019.10.41019-xxx
• VS Code version: 1.38.1
• Setting python.jediEnabled: true
• Python and/or Anaconda version: 3.6.7
• OS: Linux (Ubuntu through WSL):
• Virtual environment: conda

Developer Tools Console Output

None# Bug: Notebook Editor, Interactive Window, Python Editor cells

Steps to cause the bug to occur

1. Open .ipynb file with this extension enabled.
2. Press ctrl + F to search the file.

Actual & Expected behavior

Expected: two panel git diff pops up with changes
Actual: It seems as though VS Code tries to open the git diff view, but that tab closes and we are returned to the single notebook view.

Your Jupyter and/or Python environment

Please provide as much info as you readily know

• Jupyter server running: Local (I think? I didn't start anything, but there is a kernel running)
• Extension version: 2019.10.41019-xxx
• VS Code version: 1.38.1
• Setting python.jediEnabled: true
• Python and/or Anaconda version: 3.6.7
• OS: Linux (Ubuntu through WSL):
• Virtual environment: conda

Developer Tools Console Output

None

[jmew]

Thank you for the bug report.

[rchiodo]

@DonJayamanne I'm not sure this is working. The editor still opens. Was the fix supposed to prevent our editor from opening?

[DonJayamanne]

Yes thats correct.
Please could you provide the steps to replicate this issue (what did you click, icon or the file name?)

[rchiodo]

1. Create new blank jupyter notebook in a directory that's under git
2. Add a cell
3. Save
4. Go to the git tab in VS code and double click the ipynb

Expected result:
Just the diff window opens.

Actual result:
Diff window opens and our editor.

[DonJayamanne]

@rchiodo We have fixed it (works in Mac correctly).
There's a bug in VS Code windows that causes the onDidOpenTextDocument to get fired with the wrong information.

Upstream issue (Windows bug) microsoft/vscode#82636

[rchiodo]

I believe this is merged now, right? We can validate?

[DonJayamanne]

Yes

[IanMatthewHuff]

Validated on Mac.