PyEnvs: Register proxies with the DI framework to replace @injectable usage.

src/client/common/process/pythonExecutionFactory.ts

@@ -10,7 +10,6 @@ import { ICondaService, IInterpreterService } from '../../interpreter/contracts'
 import { IWindowsStoreInterpreter } from '../../interpreter/locators/types';
 import { IServiceContainer } from '../../ioc/types';
 import { CondaEnvironmentInfo } from '../../pythonEnvironments/discovery/locators/services/conda';
-import { WindowsStoreInterpreter } from '../../pythonEnvironments/discovery/locators/services/windowsStoreInterpreter';
 import { sendTelemetryEvent } from '../../telemetry';
 import { EventName } from '../../telemetry/constants';
 import { traceError } from '../logger';
@@ -51,7 +50,7 @@ export class PythonExecutionFactory implements IPythonExecutionFactory {
         @inject(IConfigurationService) private readonly configService: IConfigurationService,
         @inject(ICondaService) private readonly condaService: ICondaService,
         @inject(IBufferDecoder) private readonly decoder: IBufferDecoder,
-        @inject(WindowsStoreInterpreter) private readonly windowsStoreInterpreter: IWindowsStoreInterpreter,
+        @inject(IWindowsStoreInterpreter) private readonly windowsStoreInterpreter: IWindowsStoreInterpreter,
         @inject(IPlatformService) private readonly platformService: IPlatformService
     ) {
         // Acquire other objects here so that if we are called during dispose they are available.

src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts

@@ -3,15 +3,10 @@
 
 'use strict';
 
-import { inject, injectable, named } from 'inversify';
+import { inject, injectable } from 'inversify';
 import { Uri } from 'vscode';
 import '../../../common/extensions';
-import {
-    IInterpreterLocatorService,
-    IInterpreterService,
-    IPipEnvService,
-    PIPENV_SERVICE
-} from '../../../interpreter/contracts';
+import { IInterpreterService, IPipEnvService } from '../../../interpreter/contracts';
 import { InterpreterType } from '../../../pythonEnvironments/info';
 import { IWorkspaceService } from '../../application/types';
 import { IFileSystem } from '../../platform/types';
@@ -21,9 +16,7 @@ import { ITerminalActivationCommandProvider, TerminalShellType } from '../types'
 export class PipEnvActivationCommandProvider implements ITerminalActivationCommandProvider {
     constructor(
         @inject(IInterpreterService) private readonly interpreterService: IInterpreterService,
-        @inject(IInterpreterLocatorService)
-        @named(PIPENV_SERVICE)
-        private readonly pipenvService: IPipEnvService,
+        @inject(IPipEnvService) private readonly pipenvService: IPipEnvService,
         @inject(IWorkspaceService) private readonly workspaceService: IWorkspaceService,
         @inject(IFileSystem) private readonly fs: IFileSystem
     ) {}

src/client/interpreter/contracts.ts

@@ -89,7 +89,7 @@ export interface IInterpreterHelper {
 }
 
 export const IPipEnvService = Symbol('IPipEnvService');
-export interface IPipEnvService extends IInterpreterLocatorService {
+export interface IPipEnvService {
     executable: string;
     isRelatedPipEnvironment(dir: string, pythonPath: string): Promise<boolean>;
 }
@@ -99,11 +99,15 @@ export interface IInterpreterLocatorHelper {
     mergeInterpreters(interpreters: PythonInterpreter[]): Promise<PythonInterpreter[]>;
 }
 
-export const IInterpreterWatcher = Symbol('IInterpreterWatcher');
 export interface IInterpreterWatcher {
     onDidCreate: Event<Resource>;
 }
 
+export const IInterpreterWatcherRegistry = Symbol('IInterpreterWatcherRegistry');
+export interface IInterpreterWatcherRegistry extends IInterpreterWatcher {
+    register(resource: Resource): Promise<void>;
+}
+
 export const IInterpreterWatcherBuilder = Symbol('IInterpreterWatcherBuilder');
 export interface IInterpreterWatcherBuilder {
     getWorkspaceVirtualEnvInterpreterWatcher(resource: Resource): Promise<IInterpreterWatcher>;

src/client/interpreter/helpers.ts

@@ -7,7 +7,6 @@ import { IPythonExecutionFactory } from '../common/process/types';
 import { IPersistentStateFactory, Resource } from '../common/types';
 import { IServiceContainer } from '../ioc/types';
 import { isMacDefaultPythonPath } from '../pythonEnvironments/discovery';
-import { InterpeterHashProviderFactory } from '../pythonEnvironments/discovery/locators/services/hashProviderFactory';
 import {
     getInterpreterTypeName,
     InterpreterInformation,
@@ -49,7 +48,7 @@ export class InterpreterHelper implements IInterpreterHelper {
     private readonly persistentFactory: IPersistentStateFactory;
     constructor(
         @inject(IServiceContainer) private serviceContainer: IServiceContainer,
-        @inject(InterpeterHashProviderFactory) private readonly hashProviderFactory: IInterpreterHashProviderFactory
+        @inject(IInterpreterHashProviderFactory) private readonly hashProviderFactory: IInterpreterHashProviderFactory
     ) {
         this.persistentFactory = this.serviceContainer.get<IPersistentStateFactory>(IPersistentStateFactory);
     }

src/client/interpreter/interpreterService.ts

@@ -20,7 +20,6 @@ import {
 } from '../common/types';
 import { sleep } from '../common/utils/async';
 import { IServiceContainer } from '../ioc/types';
-import { InterpeterHashProviderFactory } from '../pythonEnvironments/discovery/locators/services/hashProviderFactory';
 import { InterpreterType, PythonInterpreter } from '../pythonEnvironments/info';
 import { captureTelemetry } from '../telemetry';
 import { EventName } from '../telemetry/constants';
@@ -70,7 +69,7 @@ export class InterpreterService implements Disposable, IInterpreterService {
 
     constructor(
         @inject(IServiceContainer) private serviceContainer: IServiceContainer,
-        @inject(InterpeterHashProviderFactory) private readonly hashProviderFactory: IInterpreterHashProviderFactory
+        @inject(IInterpreterHashProviderFactory) private readonly hashProviderFactory: IInterpreterHashProviderFactory
     ) {
         this.locator = serviceContainer.get<IInterpreterLocatorService>(
             IInterpreterLocatorService,

src/client/interpreter/locators/types.ts

@@ -15,6 +15,7 @@ export interface IPipEnvServiceHelper {
     trackWorkspaceFolder(pythonPath: string, workspaceFolder: Uri): Promise<void>;
 }
 
+export const IInterpreterHashProviderFactory = Symbol('IInterpreterHashProviderFactory');
 /**
  * Factory to create a hash provider.
  * Getting the hash of an interpreter can vary based on the type of the interpreter.
@@ -26,6 +27,7 @@ export interface IInterpreterHashProviderFactory {
     create(options: { pythonPath: string } | { resource: Uri }): Promise<IInterpreterHashProvider>;
 }
 
+export const IInterpreterHashProvider = Symbol('IInterpreterHashProvider');
 /**
  * Provides the ability to get the has of a given interpreter.
  *
@@ -44,6 +46,10 @@ export interface IInterpreterHashProvider {
     getInterpreterHash(pythonPath: string): Promise<string>;
 }
 
+export const IWindowsStoreHashProvider = Symbol('IWindowStoreHashProvider');
+export interface IWindowsStoreHashProvider extends IInterpreterHashProvider {}
+
+export const IWindowsStoreInterpreter = Symbol('IWindowsStoreInterpreter');
 export interface IWindowsStoreInterpreter {
     /**
      * Whether this is a Windows Store/App Interpreter.

src/client/interpreter/virtualEnvs/index.ts

@@ -14,7 +14,7 @@ import { IServiceContainer } from '../../ioc/types';
 import * as globalenvs from '../../pythonEnvironments/discovery/globalenv';
 import * as subenvs from '../../pythonEnvironments/discovery/subenv';
 import { InterpreterType } from '../../pythonEnvironments/info';
-import { IInterpreterLocatorService, IPipEnvService, PIPENV_SERVICE } from '../contracts';
+import { IPipEnvService } from '../contracts';
 import { IVirtualEnvironmentManager } from './types';
 
 @injectable()
@@ -26,10 +26,7 @@ export class VirtualEnvironmentManager implements IVirtualEnvironmentManager {
     constructor(@inject(IServiceContainer) private readonly serviceContainer: IServiceContainer) {
         this.processServiceFactory = serviceContainer.get<IProcessServiceFactory>(IProcessServiceFactory);
         this.fs = serviceContainer.get<IFileSystem>(IFileSystem);
-        this.pipEnvService = serviceContainer.get<IInterpreterLocatorService>(
-            IInterpreterLocatorService,
-            PIPENV_SERVICE
-        ) as IPipEnvService;
+        this.pipEnvService = serviceContainer.get<IPipEnvService>(IPipEnvService);
         this.workspaceService = serviceContainer.get<IWorkspaceService>(IWorkspaceService);
     }
 

src/client/pythonEnvironments/discovery/locators/helpers.ts

@@ -1,10 +1,9 @@
 import * as fsapi from 'fs-extra';
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import * as path from 'path';
 import { traceError } from '../../../common/logger';
 import { IS_WINDOWS } from '../../../common/platform/constants';
 import { IFileSystem } from '../../../common/platform/types';
-import { IInterpreterLocatorHelper } from '../../../interpreter/contracts';
 import { IPipEnvServiceHelper } from '../../../interpreter/locators/types';
 import { InterpreterType, PythonInterpreter } from '../../info';
 
@@ -26,8 +25,7 @@ export async function lookForInterpretersInDirectory(pathToCheck: string, _: IFi
     }
 }
 
-@injectable()
-export class InterpreterLocatorHelper implements IInterpreterLocatorHelper {
+export class InterpreterLocatorHelper {
     constructor(
         @inject(IFileSystem) private readonly fs: IFileSystem,
         @inject(IPipEnvServiceHelper) private readonly pipEnvServiceHelper: IPipEnvServiceHelper

src/client/pythonEnvironments/discovery/locators/index.ts

@@ -1,8 +1,7 @@
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import { Disposable, Event, EventEmitter, Uri } from 'vscode';
 import { traceDecorators } from '../../../common/logger';
 import { IPlatformService } from '../../../common/platform/types';
-import { IDisposableRegistry } from '../../../common/types';
 import { createDeferred, Deferred } from '../../../common/utils/async';
 import { OSType } from '../../../common/utils/platform';
 import {
@@ -28,8 +27,7 @@ const flatten = require('lodash/flatten') as typeof import('lodash/flatten');
 /**
  * Facilitates locating Python interpreters.
  */
-@injectable()
-export class PythonInterpreterLocatorService implements IInterpreterLocatorService {
+export class PythonInterpreterLocatorService {
     public didTriggerInterpreterSuggestions: boolean;
 
     private readonly disposables: Disposable[] = [];
@@ -39,7 +37,6 @@ export class PythonInterpreterLocatorService implements IInterpreterLocatorServi
 
     constructor(@inject(IServiceContainer) private serviceContainer: IServiceContainer) {
         this._hasInterpreters = createDeferred<boolean>();
-        serviceContainer.get<Disposable[]>(IDisposableRegistry).push(this);
         this.platform = serviceContainer.get<IPlatformService>(IPlatformService);
         this.interpreterLocatorHelper = serviceContainer.get<IInterpreterLocatorHelper>(IInterpreterLocatorHelper);
         this.didTriggerInterpreterSuggestions = false;

src/client/pythonEnvironments/discovery/locators/progressService.ts

@@ -3,18 +3,17 @@
 
 'use strict';
 
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import { Disposable, Event, EventEmitter } from 'vscode';
 import { traceDecorators } from '../../../common/logger';
 import { IDisposableRegistry } from '../../../common/types';
 import { createDeferredFrom, Deferred } from '../../../common/utils/async';
 import { noop } from '../../../common/utils/misc';
-import { IInterpreterLocatorProgressService, IInterpreterLocatorService } from '../../../interpreter/contracts';
+import { IInterpreterLocatorService } from '../../../interpreter/contracts';
 import { IServiceContainer } from '../../../ioc/types';
 import { PythonInterpreter } from '../../info';
 
-@injectable()
-export class InterpreterLocatorProgressService implements IInterpreterLocatorProgressService {
+export class InterpreterLocatorProgressService {
     private deferreds: Deferred<PythonInterpreter[]>[] = [];
     private readonly refreshing = new EventEmitter<void>();
     private readonly refreshed = new EventEmitter<void>();

src/client/pythonEnvironments/discovery/locators/services/KnownPathsService.ts

@@ -1,5 +1,5 @@
 // tslint:disable:no-require-imports no-var-requires no-unnecessary-callback-wrapper
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import * as path from 'path';
 import { Uri } from 'vscode';
 import { IFileSystem, IPlatformService } from '../../../../common/platform/types';
@@ -14,7 +14,6 @@ const flatten = require('lodash/flatten') as typeof import('lodash/flatten');
 /**
  * Locates "known" paths.
  */
-@injectable()
 export class KnownPathsService extends CacheableLocatorService {
     public constructor(
         @inject(IKnownSearchPathsForInterpreters) private knownSearchPaths: IKnownSearchPathsForInterpreters,
@@ -84,8 +83,7 @@ export class KnownPathsService extends CacheableLocatorService {
     }
 }
 
-@injectable()
-export class KnownSearchPathsForInterpreters implements IKnownSearchPathsForInterpreters {
+export class KnownSearchPathsForInterpreters {
     constructor(@inject(IServiceContainer) private readonly serviceContainer: IServiceContainer) {}
     /**
      * Return the paths where Python interpreters might be found.

src/client/pythonEnvironments/discovery/locators/services/baseVirtualEnvService.ts

@@ -1,6 +1,5 @@
 // tslint:disable:no-unnecessary-callback-wrapper no-require-imports no-var-requires
 
-import { injectable, unmanaged } from 'inversify';
 import * as path from 'path';
 import { Uri } from 'vscode';
 import { traceError } from '../../../../common/logger';
@@ -13,16 +12,15 @@ import { lookForInterpretersInDirectory } from '../helpers';
 import { CacheableLocatorService } from './cacheableLocatorService';
 const flatten = require('lodash/flatten') as typeof import('lodash/flatten');
 
-@injectable()
 export class BaseVirtualEnvService extends CacheableLocatorService {
     private readonly virtualEnvMgr: IVirtualEnvironmentManager;
     private readonly helper: IInterpreterHelper;
     private readonly fileSystem: IFileSystem;
     public constructor(
-        @unmanaged() private searchPathsProvider: IVirtualEnvironmentsSearchPathProvider,
-        @unmanaged() serviceContainer: IServiceContainer,
-        @unmanaged() name: string,
-        @unmanaged() cachePerWorkspace: boolean = false
+        private searchPathsProvider: IVirtualEnvironmentsSearchPathProvider,
+        serviceContainer: IServiceContainer,
+        name: string,
+        cachePerWorkspace: boolean = false
     ) {
         super(name, serviceContainer, cachePerWorkspace);
         this.virtualEnvMgr = serviceContainer.get<IVirtualEnvironmentManager>(IVirtualEnvironmentManager);

src/client/pythonEnvironments/discovery/locators/services/cacheableLocatorService.ts

@@ -3,7 +3,6 @@
 
 // tslint:disable:no-any
 
-import { injectable, unmanaged } from 'inversify';
 import * as md5 from 'md5';
 import { Disposable, Event, EventEmitter, Uri } from 'vscode';
 import { IWorkspaceService } from '../../../../common/application/types';
@@ -60,7 +59,6 @@ export class CacheableLocatorPromiseCache {
     }
 }
 
-@injectable()
 export abstract class CacheableLocatorService implements IInterpreterLocatorService {
     protected readonly _hasInterpreters: Deferred<boolean>;
     private readonly promisesPerResource = new CacheableLocatorPromiseCache();
@@ -70,9 +68,9 @@ export abstract class CacheableLocatorService implements IInterpreterLocatorServ
     private _didTriggerInterpreterSuggestions: boolean;
 
     constructor(
-        @unmanaged() private readonly name: string,
-        @unmanaged() protected readonly serviceContainer: IServiceContainer,
-        @unmanaged() private cachePerWorkspace: boolean = false
+        private readonly name: string,
+        protected readonly serviceContainer: IServiceContainer,
+        private cachePerWorkspace: boolean = false
     ) {
         this._hasInterpreters = createDeferred<boolean>();
         this.cacheKeyPrefix = `INTERPRETERS_CACHE_v3_${name}`;

src/client/pythonEnvironments/discovery/locators/services/condaEnvFileService.ts

@@ -8,7 +8,7 @@
  * More details: https://github.com/microsoft/vscode-python/issues/8886
  */
 
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import * as path from 'path';
 import { Uri } from 'vscode';
 import { traceError } from '../../../../common/logger';
@@ -22,7 +22,6 @@ import { AnacondaCompanyName } from './conda';
 /**
  * Locate conda env interpreters based on the "conda environments file".
  */
-@injectable()
 export class CondaEnvFileService extends CacheableLocatorService {
     constructor(
         @inject(IInterpreterHelper) private helperService: IInterpreterHelper,

src/client/pythonEnvironments/discovery/locators/services/condaEnvService.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import { Uri } from 'vscode';
 import { traceError } from '../../../../common/logger';
 import { IFileSystem } from '../../../../common/platform/types';
@@ -14,7 +14,6 @@ import { parseCondaInfo } from './conda';
 /**
  * Locates conda env interpreters based on the conda service's info.
  */
-@injectable()
 export class CondaEnvService extends CacheableLocatorService {
     constructor(
         @inject(ICondaService) private condaService: ICondaService,

src/client/pythonEnvironments/discovery/locators/services/condaService.ts

@@ -1,4 +1,4 @@
-import { inject, injectable, named, optional } from 'inversify';
+import { inject, named, optional } from 'inversify';
 import * as path from 'path';
 import { compare, parse, SemVer } from 'semver';
 import { ConfigurationChangeEvent, Uri } from 'vscode';
@@ -9,7 +9,7 @@ import { IFileSystem, IPlatformService } from '../../../../common/platform/types
 import { IProcessServiceFactory } from '../../../../common/process/types';
 import { IConfigurationService, IDisposableRegistry, IPersistentStateFactory } from '../../../../common/types';
 import { cache } from '../../../../common/utils/decorators';
-import { ICondaService, IInterpreterLocatorService, WINDOWS_REGISTRY_SERVICE } from '../../../../interpreter/contracts';
+import { IInterpreterLocatorService, WINDOWS_REGISTRY_SERVICE } from '../../../../interpreter/contracts';
 import { InterpreterType, PythonInterpreter } from '../../../info';
 import { CondaEnvironmentInfo, CondaInfo } from './conda';
 import { parseCondaEnvFileContents } from './condaHelper';
@@ -48,8 +48,7 @@ export const CondaGetEnvironmentPrefix = 'Outputting Environment Now...';
 /**
  * A wrapper around a conda installation.
  */
-@injectable()
-export class CondaService implements ICondaService {
+export class CondaService {
     private condaFile?: Promise<string | undefined>;
     private isAvailable: boolean | undefined;
 

src/client/pythonEnvironments/discovery/locators/services/currentPathService.ts

@@ -1,5 +1,5 @@
 // tslint:disable:no-require-imports no-var-requires underscore-consistent-invocation no-unnecessary-callback-wrapper
-import { inject, injectable } from 'inversify';
+import { inject } from 'inversify';
 import { Uri } from 'vscode';
 import { traceError, traceInfo } from '../../../../common/logger';
 import { IFileSystem, IPlatformService } from '../../../../common/platform/types';
@@ -19,7 +19,6 @@ import { CacheableLocatorService } from './cacheableLocatorService';
  * If no interpreter is configured then it falls back to the system
  * Python (3 then 2).
  */
-@injectable()
 export class CurrentPathService extends CacheableLocatorService {
     private readonly fs: IFileSystem;
 
@@ -125,8 +124,7 @@ export class CurrentPathService extends CacheableLocatorService {
     }
 }
 
-@injectable()
-export class PythonInPathCommandProvider implements IPythonInPathCommandProvider {
+export class PythonInPathCommandProvider {
     constructor(@inject(IPlatformService) private readonly platform: IPlatformService) {}
     public getCommands(): { command: string; args?: string[] }[] {
         const paths = ['python3.7', 'python3.6', 'python3', 'python2', 'python'].map((item) => {