PyEnvs: Register proxies with the DI framework to replace @injectable usage. #12795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
py-envs-ioc-move-to-surface
branch
from
da59bec to
73d82d3
Compare
karthiknadig
approved these changes
Jul 7, 2020
ericsnowcurrently
force-pushed
the
py-envs-ioc-move-to-surface
branch
from
73d82d3 to
d80276b
Compare
ericsnowcurrently
force-pushed
the
py-envs-ioc-move-to-surface
branch
from
d80276b to
78fc597
Compare
ericsnowcurrently
force-pushed
the
py-envs-ioc-move-to-surface
branch
from
1fa7a58 to
fa2ec88
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ericsnowcurrently
added a commit
that referenced
this pull request
Jul 22, 2020
ericsnowcurrently
added a commit
to ericsnowcurrently/vscode-python
that referenced
this pull request
Aug 4, 2020
…jectable usage. (microsoft#12795)" This reverts commit 3016ad8.
ericsnowcurrently
added a commit
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following with each class in the component that has the
@injectabledecorator:@injectabledecorator from the component-internal classNote that this change does the absolute minimum. No classes are refactored. No code is pulled up into the proxies, no matter how basic. Also note that the
@injectdecorators are left behind to make it easier to identify where separate refactoring needs to happen (per our plans).The review for the PR should be trivial.