Closing a notebook marked as trusted shouldn't trigger the save modal #12904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
joyceerhl
requested review from
a team,
DavidKutu,
DonJayamanne,
IanMatthewHuff and
rchiodo
and removed request for
a team
| // Dirty state comes from undo. At least VS code will track it that way. However | ||
| // skip file changes as we don't forward those to VS code | ||
| if (change.kind !== 'save' && change.kind !== 'saveAs') { | ||
| if (change.kind !== 'save' && change.kind !== 'saveAs' && change.kind !== 'updateTrust') { |
There was a problem hiding this comment.
Looks like this is one of those where a test would have been good. No need of tests now.
DonJayamanne
approved these changes
Jul 13, 2020
DonJayamanne
pushed a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12867
Don't increase model change count when trust updates
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).