Skip to content

Closing a notebook marked as trusted shouldn't trigger the save modal #12904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Closing a notebook marked as trusted shouldn't trigger the save modal #12904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/datascience/notebookStorage/notebookModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class NativeEditorNotebookModel extends BaseNotebookModel {

// Dirty state comes from undo. At least VS code will track it that way. However
// skip file changes as we don't forward those to VS code
if (change.kind !== 'save' && change.kind !== 'saveAs') {
if (change.kind !== 'save' && change.kind !== 'saveAs' && change.kind !== 'updateTrust') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is one of those where a test would have been good. No need of tests now.

this.changeCount += 1;
}

Expand Down