Increase a timeout to get a "standard" test passing. #13098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #13098 +/- ##
=========================================
Coverage ? 59.76%
=========================================
Files ? 671
Lines ? 36681
Branches ? 5158
=========================================
Hits ? 21924
Misses ? 13661
Partials ? 1096
Continue to review full report at Codecov.
|
karthiknadig
approved these changes
Jul 22, 2020
karrtikr
reviewed
Jul 22, 2020
There was a problem hiding this comment.
It would have been great if we could get to the bottom of why it started taking more time, but that's probably not as easy as it sounds? @ericsnowcurrently
This was referenced Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for #12833)
[ ] Appropriate comments and documentation strings in the code.[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Unit tests & system/integration tests are added/updated.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.