Skip to content

Increase a timeout to get a "standard" test passing. #13098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Increase a timeout to get a "standard" test passing. #13098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3beccf0
Set a higher timeout for the VirtualEnv Service test.
ericsnowcurrently Jul 22, 2020
db09f86
Add a NEWS entry.
ericsnowcurrently Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions news/2 Fixes/12833.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The change in PR #12795 led to one particular test suite to take longer
to run. Here we increase the timeout for that suite to get the test
passing.
3 changes: 2 additions & 1 deletion src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ class Venvs {
}
}

const timeoutMs = IS_CI_SERVER ? 60_000 : 15_000;
const baseTimeoutMs = 30_000;
const timeoutMs = IS_CI_SERVER ? baseTimeoutMs * 4 : baseTimeoutMs;
suite('Interpreters - Workspace VirtualEnv Service', function () {
this.timeout(timeoutMs);
this.retries(0);
Expand Down