Skip to content

Conversation

ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Aug 4, 2020

This reverts commit 3016ad8.

(for #12833)

We will work on un-reverting separately.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Aug 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #13278 into master will decrease coverage by 0.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13278      +/-   ##
==========================================
- Coverage   59.80%   58.82%   -0.98%     
==========================================
  Files         670      670              
  Lines       37183    39617    +2434     
  Branches     5265     6027     +762     
==========================================
+ Hits        22237    23306    +1069     
- Misses      13818    15118    +1300     
- Partials     1128     1193      +65     
Impacted Files Coverage Δ
src/client/interpreter/locators/types.ts 100.00% <ø> (ø)
...rc/client/common/process/pythonExecutionFactory.ts 87.25% <100.00%> (ø)
...entActivationProviders/pipEnvActivationProvider.ts 65.51% <100.00%> (ø)
src/client/interpreter/contracts.ts 100.00% <100.00%> (ø)
src/client/interpreter/helpers.ts 50.68% <100.00%> (ø)
src/client/interpreter/interpreterService.ts 65.62% <100.00%> (ø)
src/client/interpreter/virtualEnvs/index.ts 75.64% <100.00%> (ø)
...t/pythonEnvironments/discovery/locators/helpers.ts 70.58% <100.00%> (ø)
...ent/pythonEnvironments/discovery/locators/index.ts 85.71% <100.00%> (+0.60%) ⬆️
...Environments/discovery/locators/progressService.ts 100.00% <100.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2d404...a592daf. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karrtikr karrtikr requested a review from karthiknadig August 11, 2020 19:03
@ericsnowcurrently ericsnowcurrently merged commit da06067 into microsoft:master Aug 11, 2020
@ericsnowcurrently ericsnowcurrently deleted the fix-12833-revert branch August 11, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants