Skip to content

Conversation

karthiknadig
Copy link
Member

For #14614

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@karthiknadig karthiknadig merged commit 8174a6c into microsoft:main Nov 5, 2020
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Nov 6, 2020
* Update shipped wheels version

* News item
karthiknadig added a commit that referenced this pull request Nov 6, 2020
* Update shipped wheels version (#14615)

* Update shipped wheels version

* News item

* Remove redundant files (#14620)

* Add extension dependencies at build time (#14636)

* Use Node 12.15 in Insiders and Release GitHub Actions (#14641)

* Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
karthiknadig added a commit that referenced this pull request Nov 26, 2020
* Cherry pick from main (#14644)

* Update shipped wheels version (#14615)

* Update shipped wheels version

* News item

* Remove redundant files (#14620)

* Add extension dependencies at build time (#14636)

* Use Node 12.15 in Insiders and Release GitHub Actions (#14641)

* Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* Cherry pic fixes into release for tests. (#14673)

* Added FSWatching base class and made related changes (#14605)

* Add FSWatching locator base class

* Correct glob pattern to not match python3.2whoa

* Add documentation of python binary watcher

* Fix lint errors

* Update ignore list

* Add disposable registry

* Modify FSWatching Locator

* Code reviews

* Use string[]

* Remove list disposable getter

* Fix failing global virtual env watcher tests (#14633)

Co-authored-by: Kartik Raj <karraj@microsoft.com>

* Version, change log and cherrypicks for nov release (#14696)

* change log updates

* Update gifs

* Fix for interpreter selection (#14693)

* Fix for interpreter selection

* Fix linting errors

* Minor tweak to property removal

* Cherry pick "Bind function to correct this for workspace syms" (#14743)

* Fix #14674: Enable overriding "pythonPath" in the launcher

Fix #12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".

* Point release change log and version update (#14750)

* Point release change log and version update

* Fix process picker (#14700)

* Workaround VSCode bug for process picker

* Fix how we pass in icons to VSCode

* update change log with cherry pick

Co-authored-by: Kartik Raj <karraj@microsoft.com>

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: Pavel Minaev <pminaev@microsoft.com>
@karthiknadig karthiknadig deleted the dbg1 branch December 10, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants