Skip to content

Merge commits from master #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2019
Merged

Merge commits from master #5760

merged 3 commits into from
May 24, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented May 24, 2019

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

rchiodo added 3 commits May 24, 2019 08:25
@rchiodo
Fix command prompt to look like Spyder (#5744)
5c99a53 
* Fix command prompt to look like Spyder

* Add news entry
@rchiodo
Fix magics and comments parsing (#5746)
6104071 
* Fix magics and comments parsing

* Fix mime types without real jupyter
@rchiodo
Fix scrolling (#5747)
0e41049
@rchiodo rchiodo requested a review from IanMatthewHuff May 24, 2019 15:27
@rchiodo rchiodo self-assigned this May 24, 2019
@rchiodo rchiodo merged commit d79ffd5 into release May 24, 2019
@rchiodo rchiodo deleted the rchiodo/release_merge branch May 28, 2019 16:05
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees

@rchiodo rchiodo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rchiodo