Skip to content

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Oct 7, 2019

For #7365
Missing tests for toggle line, toggle markup and code.

When reviewing, please ignore white space when comparing the changes..

Two tests have been disabled due to https://github.com/microsoft/vscode-python/issues/7802

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Oct 7, 2019
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #7797 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7797   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files         498      498           
  Lines       22256    22256           
  Branches     3579     3579           
=======================================
  Hits        13166    13166           
  Misses       8266     8266           
  Partials      824      824

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9bf45...5769020. Read the comment docs.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit d4c5607 into microsoft:master Oct 8, 2019
rchiodo pushed a commit that referenced this pull request Oct 10, 2019
* Tests  for keyboard shortcuts
* Added some more tests
* Code review comments
* Fix merge issues
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
@DonJayamanne DonJayamanne deleted the testsFor7365 branch April 30, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants