Skip to content

Tests for keyboard shortcuts in native editor #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 8, 2019
Merged

Tests for keyboard shortcuts in native editor #7797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ad0fdca
Tests for keyboard shortcuts
DonJayamanne Oct 7, 2019
7c487dd
Fixes
DonJayamanne Oct 7, 2019
dbefb8f
Oops
DonJayamanne Oct 7, 2019
d09f795
Disable broken tests
DonJayamanne Oct 7, 2019
2f6b415
Added some more tests
DonJayamanne Oct 7, 2019
a084cb5
More fixes
DonJayamanne Oct 8, 2019
065c897
Fixes to tests
DonJayamanne Oct 8, 2019
0c3f0c5
Code review comments
DonJayamanne Oct 8, 2019
5769020
Fix merge issues
DonJayamanne Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datascience-ui/interactive-common/cellOutput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export class CellOutput extends React.Component<ICellOutputProps> {
const Transform = transforms['text/markdown'];
const MarkdownClassName = 'markdown-cell-output';

return [<div className={MarkdownClassName}><Transform key={0} data={source} /></div>];
return [<div key={0} className={MarkdownClassName}><Transform key={0} data={source} /></div>];
}

// tslint:disable-next-line: max-func-body-length
Expand Down
2 changes: 1 addition & 1 deletion src/datascience-ui/react-common/monacoEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface IMonacoEditorProps {
lineCountChanged(newCount: number): void;
}

interface IMonacoEditorState {
export interface IMonacoEditorState {
editor?: monacoEditor.editor.IStandaloneCodeEditor;
model: monacoEditor.editor.ITextModel | null;
visibleLineCount: number;
Expand Down
Loading