Skip to content

Conversation

DonJayamanne
Copy link

For #7832

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #7833 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7833      +/-   ##
==========================================
- Coverage   59.25%   58.93%   -0.32%     
==========================================
  Files         498      498              
  Lines       22295    22295              
  Branches     3580     3575       -5     
==========================================
- Hits        13210    13139      -71     
- Misses       8263     8334      +71     
  Partials      822      822
Impacted Files Coverage Δ
src/client/testing/serviceRegistry.ts 48.64% <0%> (-46.85%) ⬇️
src/client/testing/codeLenses/main.ts 44.44% <0%> (-33.34%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 66.66% <0%> (-33.34%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
src/client/common/utils/icons.ts 83.33% <0%> (-16.67%) ⬇️
src/client/api.ts 78.57% <0%> (-14.29%) ⬇️
src/client/datascience/cellFactory.ts 75.86% <0%> (-13.8%) ⬇️
src/client/providers/providerUtilities.ts 83.33% <0%> (-5.56%) ⬇️
src/client/common/utils/version.ts 77.77% <0%> (-3.71%) ⬇️
src/client/language/characters.ts 30.76% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe2a76...0f07b21. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 221b8b3 into microsoft:master Oct 9, 2019
rchiodo pushed a commit that referenced this pull request Oct 10, 2019
* Update vscode dependency
* News entry
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
@DonJayamanne DonJayamanne deleted the updateVSCode branch April 30, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants