Skip to content

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Oct 9, 2019

For #7834

Depends on PR (#7833) to update the package.json

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #7835 into master will decrease coverage by 0.67%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7835      +/-   ##
==========================================
- Coverage   59.25%   58.57%   -0.68%     
==========================================
  Files         498      498              
  Lines       22295    21932     -363     
  Branches     3580     3575       -5     
==========================================
- Hits        13210    12847     -363     
  Misses       8263     8263              
  Partials      822      822
Impacted Files Coverage Δ
src/client/common/application/webPanel.ts 18.18% <25%> (+0.79%) ⬆️
...nt/datascience/jupyter/invalidNotebookFileError.ts 0% <0%> (-75%) ⬇️
.../client/datascience/jupyter/jupyterConnectError.ts 0% <0%> (-66.67%) ⬇️
...science/jupyter/jupyterKernelPromiseFailedError.ts 0% <0%> (-50%) ⬇️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 0% <0%> (-50%) ⬇️
src/client/language/characters.ts 12% <0%> (-21.34%) ⬇️
src/client/testing/codeLenses/main.ts 60% <0%> (-17.78%) ⬇️
src/client/datascience/cellFactory.ts 72.34% <0%> (-17.32%) ⬇️
src/client/constants.ts 75% <0%> (-5%) ⬇️
src/client/providers/providerUtilities.ts 84.61% <0%> (-4.28%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe2a76...5b0268d. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 8ac8da2 into microsoft:master Oct 9, 2019
rchiodo pushed a commit that referenced this pull request Oct 10, 2019
…7835)

* Update vscode dependency
* News entry
* Stop hardcoding 'vscode-resource' and use VSC api
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
@DonJayamanne DonJayamanne deleted the fixWebView branch December 17, 2019 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants