Skip to content

Conversation

karthiknadig
Copy link
Member

For #8460

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated

@karthiknadig karthiknadig added the no-changelog No news entry required label Nov 8, 2019
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #8461 into master will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8461      +/-   ##
==========================================
+ Coverage   59.39%   59.41%   +0.01%     
==========================================
  Files         509      509              
  Lines       23423    23430       +7     
  Branches     3786     3787       +1     
==========================================
+ Hits        13913    13920       +7     
- Misses       8604     8605       +1     
+ Partials      906      905       -1
Impacted Files Coverage Δ
src/client/telemetry/index.ts 87.12% <ø> (+0.99%) ⬆️
src/client/telemetry/constants.ts 100% <100%> (ø) ⬆️
src/client/datascience/jupyter/jupyterDebugger.ts 10.47% <11.11%> (ø) ⬆️
src/client/debugger/extension/adapter/factory.ts 92.98% <90.9%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6295bee...a1a0afb. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review November 8, 2019 21:56
@karthiknadig karthiknadig merged commit 8874744 into microsoft:master Nov 12, 2019
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Nov 12, 2019
…el (microsoft#8461)

* Ensure wheels control group uses no wheel ptvsd
* Improve condition readability in jupyter debugger
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Nov 12, 2019
…el (microsoft#8461)

* Ensure wheels control group uses no wheel ptvsd
* Improve condition readability in jupyter debugger
karthiknadig added a commit that referenced this pull request Nov 12, 2019
…el (#8461) (#8546)

* Ensure wheels control group uses no wheel ptvsd
* Improve condition readability in jupyter debugger
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
@karthiknadig karthiknadig deleted the issue8460 branch December 27, 2019 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants