Skip to content

Conversation

karthiknadig
Copy link
Member

No description provided.

…el (microsoft#8461)

* Ensure wheels control group uses no wheel ptvsd
* Improve condition readability in jupyter debugger
@karthiknadig karthiknadig added the no-changelog No news entry required label Nov 12, 2019
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you cherry-pick #8540 in a separate PR?

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #8546 into release-2019.11 will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2019.11    #8546      +/-   ##
===================================================
+ Coverage            59.46%   59.47%   +0.01%     
===================================================
  Files                  509      509              
  Lines                23390    23397       +7     
  Branches              3779     3780       +1     
===================================================
+ Hits                 13909    13916       +7     
- Misses                8575     8576       +1     
+ Partials               906      905       -1
Impacted Files Coverage Δ
src/client/telemetry/index.ts 87.12% <ø> (+0.99%) ⬆️
src/client/telemetry/constants.ts 100% <100%> (ø) ⬆️
src/client/datascience/jupyter/jupyterDebugger.ts 10.47% <11.11%> (ø) ⬆️
src/client/debugger/extension/adapter/factory.ts 92.98% <90.9%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a689a3...2e4721a. Read the comment docs.

@karthiknadig karthiknadig merged commit 92aeeeb into microsoft:release-2019.11 Nov 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants