Skip to content

Do not override kernels info in other notebooks #9958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2020
Merged

Do not override kernels info in other notebooks #9958

merged 2 commits into from
Feb 6, 2020

Conversation

DonJayamanne
Copy link

For #9951, #9950, #9949

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 6, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #9958 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9958      +/-   ##
=========================================
+ Coverage   61.18%   61.2%   +0.01%     
=========================================
  Files         564     564              
  Lines       30077   30078       +1     
  Branches     4550    4550              
=========================================
+ Hits        18404   18408       +4     
+ Misses      10642   10640       -2     
+ Partials     1031    1030       -1
Impacted Files Coverage Δ
...datascience/jupyter/liveshare/hostJupyterServer.ts 11% <0%> (-0.12%) ⬇️
src/client/common/process/proc.ts 15.21% <0%> (+0.72%) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (+1.56%) ⬆️
src/client/linters/pydocstyle.ts 88.88% <0%> (+2.22%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad70988...a15a8f0. Read the comment docs.

IanMatthewHuff
IanMatthewHuff approved these changes Feb 6, 2020
View reviewed changes
@DonJayamanne DonJayamanne merged commit eb5cc9e into microsoft:master Feb 6, 2020
@DonJayamanne DonJayamanne deleted the fixKernelUpdate branch February 6, 2020 20:40
DonJayamanne added a commit that referenced this pull request Feb 6, 2020
@DonJayamanne
Do not override kernels info in other notebooks (#9958)
415cab4 
For #9951, #9950, #9949
* Do not override kernels info in other notebooks
* Fixes
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo Awaiting requested review from rchiodo

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @DavidKutu