Skip to content

Do not override kernels info in other notebooks #9958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Do not override kernels info in other notebooks #9958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb8bace
Do not override kernels info in other notebooks
DonJayamanne Feb 6, 2020
a15a8f0
Fixes
DonJayamanne Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/client/datascience/jupyter/liveshare/hostJupyterServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,16 @@ export class HostJupyterServer extends LiveShareParticipantHost(JupyterServerBas
// Otherwise create a new notebook.

// First we need our launch information so we can start a new session (that's what our notebook is really)
const launchInfo = await this.waitForConnect();
let launchInfo = await this.waitForConnect();
if (!launchInfo) {
throw this.getDisposedError();
}
// Create a copy of launch info, cuz we're modifying it here.
// This launch info contains the server connection info (that could be shared across other nbs).
// However the kernel info is different. The kernel info is stored as a property of this, hence create a separate instance for each nb.
launchInfo = {
...launchInfo
};

// Find a kernel that can be used.
// Do this only if kernel information has been provided in the metadata, else use the default.
Expand Down