Skip to content

Don't go to the ext host for default terminal shell/args in tasks #123732

@Tyriar

Description

@Tyriar

I noticed this call here which goes to the exthost:

defaultConfig = await variableResolver.taskSystemInfo.getDefaultShellAndArgs();

It seems to be the only usage of that proxy call, you can now call this on the renderer for the same thing:

ITerminalProfileResolverService.getDefaultProfile({
  os: terminalBackendOS, // probably remoteAgentService.getEnvironment().os || OS
  remoteAuthority: terminalBackendRemoteAuthority,
  allowAutomationShell: true
});

Metadata

Metadata

Assignees

Labels

debtCode quality issuesinsiders-releasedPatch has been released in VS Code InsiderstasksTask system issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions