Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Issue]: Dependency can't be found by main installer after it's installed #2939

Closed
2 tasks done
stephengillie opened this issue Dec 5, 2022 · 2 comments · Fixed by #3296
Closed
2 tasks done
Assignees
Labels
Area-Path Issue related to path environment variable Dependencies Blocked by microsoft/winget-cli/issues/163 Support for Dependencies In-PR Issue related to a PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@stephengillie
Copy link

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

This installer has Git as a dependency. It finds Git in the Windows Path during install to register itself. But the Windows Path in most Command Prompt and PowerShell windows appears to only update at window launch. One window must be opened for the dependency install, and then another window opened for the main package install. Observed in

Similar behavior was observed in this PR - the installer completed, but validation failed as it used the same PowerShell window, and thus couldn't find Git in the Windows Path.

Steps to reproduce

For 90133 - On new system, modify the package's manifest to have Git.Git as a dependency, then install in a VM.

Actual behavior

The installer will error "Could not find Git; can not register Git LFS."

Expected behavior

Winget could help the client window to update its local Windows Path variable from the registry, so subsequent installers could install successfully, and programs run from the same window could find Git to execute successfully.

Environment

Windows Package Manager (Preview) v1.4.3132-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1288
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.3132.0

Screenshots and Logs

No response

@stephengillie stephengillie added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Dec 5, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Dec 5, 2022
@stephengillie stephengillie removed the Needs-Triage Issue need to be triaged label Dec 5, 2022
@denelon
Copy link
Contributor

denelon commented Dec 6, 2022

@microsoft-github-policy-service

This comment was marked as off-topic.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Feb 8, 2023
@denelon denelon removed Needs-Triage Issue need to be triaged Needs-Author-Feedback Issue needs attention from issue or PR author labels Feb 8, 2023
@denelon denelon transferred this issue from microsoft/winget-pkgs Feb 8, 2023
@denelon denelon changed the title [Dependency Issue]: Git.Git as dependency can't be found by main installer after it's installed [Dependency Issue]: Dependency can't be found by main installer after it's installed Feb 8, 2023
@denelon denelon added the Dependencies Blocked by microsoft/winget-cli/issues/163 Support for Dependencies label Feb 8, 2023
@denelon denelon added this to the v1.5-Client milestone Feb 8, 2023
@yao-msft yao-msft reopened this Feb 9, 2023
@denelon denelon added the Area-Path Issue related to path environment variable label Feb 22, 2023
@denelon denelon modified the milestones: v1.5-Client, v.Next-Client Jun 6, 2023
@denelon denelon modified the milestones: v.Next-Client, v1.6 Client Jun 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR Issue related to a PR label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Path Issue related to path environment variable Dependencies Blocked by microsoft/winget-cli/issues/163 Support for Dependencies In-PR Issue related to a PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants