Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliot.UEExplorer version 1.3.1 #94562

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Eliot.UEExplorer version 1.3.1 #94562

merged 5 commits into from
Feb 15, 2023

Conversation

EliotVU
Copy link
Contributor

@EliotVU EliotVU commented Jan 24, 2023 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EliotVU
Copy link
Contributor Author

EliotVU commented Jan 24, 2023

@microsoft-github-policy-service agree

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 24, 2023
@ghost
Copy link

ghost commented Jan 24, 2023

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jan 24, 2023

EliotVU,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

mdanish-kh
mdanish-kh suggested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version listed in the Registry/Control Panel/Apps & Features is 1.3.2, but the installer URL suggests the package is for version 1.3.1. This seems unintentional, can you please confirm this?

image

manifests/e/Eliot/UEExplorer/1.3.1/Eliot.UEExplorer.locale.en-US.yaml Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 25, 2023
@ghost ghost assigned EliotVU Jan 25, 2023
@ghost
Copy link

ghost commented Jan 25, 2023

Hello @EliotVU,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Jan 26, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EliotVU
Copy link
Contributor Author

EliotVU commented Jan 26, 2023

The version listed in the Registry/Control Panel/Apps & Features is 1.3.2, but the installer URL suggests the package is for version 1.3.1. This seems unintentional, can you please confirm this?

image

Ah, the app is released as 1.3.1 but the setup package was bumped to 1.3.2 because the setup was missing some dependencies. The 1.3.2 setup still installs the 1.3.1 release.

Is that still an issue? Or do I need to make a new setup?

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

EliotVU,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 26, 2023
@ghost ghost assigned EliotVU Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Hello @EliotVU,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 30, 2023
@EliotVU EliotVU mentioned this pull request Jan 30, 2023
Closed
@EliotVU
Copy link
Contributor Author

EliotVU commented Jan 30, 2023

Upon further investigation, the setup packager is definitely listing the runtime as a prerequisite, however the released .msi setup does not include the steps to install prerequisites, instead we get two files setup.exe and ue-explorer.msi.

Where am I supposed to go from here? Is it possible to package with both the .exe and .msi files?

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 7, 2023
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@denelon
Copy link
Contributor

denelon commented Feb 8, 2023

@EliotVU I'm not sure what the steps would be to properly include the dependency in the package. We're getting closer to having the dependency feature working properly. The last lingering issue appears to be:

@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Feb 14, 2023
@stephengillie stephengillie removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 83f8a5b into microsoft:master Feb 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 15, 2023
@stephengillie
Copy link
Collaborator

The application installs and launches normally now.

@EliotVU
Copy link
Contributor Author

EliotVU commented Feb 15, 2023

Great, thanks for your time!

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdanish-kh mdanish-kh mdanish-kh requested changes

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EliotVU @wingetbot @stephengillie @denelon @mdanish-kh