Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchmycolor.ColibriBeta version 22.3.1.9988 #95510

Conversation

matchmycolor
Copy link
Contributor

@matchmycolor matchmycolor commented Feb 3, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matchmycolor
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="matchmycolor"]

@matchmycolor
Copy link
Contributor Author

@microsoft-github-policy-service agree company="matchmycolor"

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 3, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 6, 2023

Hi @matchmycolor,

This package requires the .NET Desktop Runtime 6.0.5 (x86):
image

I tried using the package Microsoft.DotNet.DesktopRuntime.6, but it must be a 64-bit package, as the installer generated the error even with it installed.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Feb 6, 2023
@matchmycolor
Copy link
Contributor Author

Yes, we have some prerequisite dependencies for .net runtimes. We also have an installer that includes these dependencies. Should we publish this installer with winget? What is the proper way of dealing with prerequisites?

@denelon
Copy link
Contributor

denelon commented Feb 8, 2023

We're working through support for dependencies. It's currently an experimental feature. The one open remaining item is updating the path for the install flow so the dependency is recognized by the "main" package to be installed.

If you publish a version including dependencies, the PR can be approved.

The schema supports referencing dependencies, but the issue mentioned above is the blocker.

auto-merge was automatically disabled March 2, 2023 15:09

Pull request was closed

@matchmycolor matchmycolor deleted the autogenerated/matchmycolor.ColibriBeta/44bfcbe9-41fb-4964-ada6-6ee82bd23dbd branch March 2, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants